-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/teams #11
Feat/teams #11
Conversation
Unused files (2)
Unused dependencies (2)
Unused exports (1)
Unused types (1)
|
@0x4007 Should I impose |
I don't really understand the full context of the question. I think in the future this makes more sense to discuss under the issue specification instead.
Core team members should have higher limits compared to external people. The check only happens upon task assignment |
given that this PR adds extends If done only against the invoker users could get around these checks but doing it against all might limit collaboration. Currently the check is performed against the command invoker only |
Checking each user seems correct based on the vision. |
QA: ubq-testing/bot-ai#27 (comment) There seems to be a bug that I cannot seem to resolve. In the QA issue no problems, it's a public repo and public tasks. I also have a private issue in my I can self assign as I am passing the array to the Have you folks encountered anything like this before? I think it's actually a feature of GitHub because I cannot dual-assign via the UI either... Should I account for this and detect if it's a private repo and comment a custom message? |
I'm not completely sure but I think that's because for private repos you need Github subscription to have that option |
https://github.com/orgs/community/discussions/7150 Seems you are correct @whilefoo. We'd need permissions to access billing to determine this I'm sure so if we are to implement some sort of custom message then would we do it by simply checking Or no custom message and deal with it if we need to later? |
I think it's fine without the messages (most orgs will have paid plans) |
If this isn't a lot of work I think just include the custom error message within this pull? Seems to me like this can be handled in a few lines of code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go for me when you addressed the remaining comments.
Resolves #6
Requires #10
QA: ubq-testing#2 (comment)